[PATCH] D110747: [NFC] Restore magic and magicu to a globally visible location

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Support/DivisionByConstantInfo.cpp:25
+  APInt signedMin = APInt::getSignedMinValue(d.getBitWidth());
+  struct SignedDivisionByConstantInfo mag;
+
----------------
With the struct being renamed, a variable called `mag` no longer makes sense. It's not an obvious abbreviation for "magic" if "magic" doesn't appear anywhere.


================
Comment at: llvm/lib/Support/DivisionByConstantInfo.cpp:69
+  APInt nc, delta, q1, r1, q2, r2;
+  struct UnsignedDivisonByConstantInfo magu;
+  magu.IsAdd = 0; // initialize "add" indicator
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110747/new/

https://reviews.llvm.org/D110747