[llvm] 79b4220 - [runtimes] Ensure required deps for tests targets are actually built

Leonard Chan via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 14:41:49 PDT 2021


Author: Leonard Chan
Date: 2021-09-29T14:41:33-07:00
New Revision: 79b422080612fec7fb720052378f448174c016c7

URL: https://github.com/llvm/llvm-project/commit/79b422080612fec7fb720052378f448174c016c7
DIFF: https://github.com/llvm/llvm-project/commit/79b422080612fec7fb720052378f448174c016c7.diff

LOG: [runtimes] Ensure required deps for tests targets are actually built

When building compiler-rt via runtimes, many tests fail because tools like
FileCheck and count aren't built yet. This is because the RUNTIME_TEST_DEPENDENCIES
haven't been added to any of the compiler-rt targets. The fix is to explicitly
add any runtimes as test_targets.

Differential Revision: https://reviews.llvm.org/D109625

Added: 
    

Modified: 
    llvm/runtimes/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/runtimes/CMakeLists.txt b/llvm/runtimes/CMakeLists.txt
index 1ec808e7ff21..7e5f9154ff76 100644
--- a/llvm/runtimes/CMakeLists.txt
+++ b/llvm/runtimes/CMakeLists.txt
@@ -294,6 +294,7 @@ function(runtime_register_target name target)
     set(runtimes-test-depends-${name} runtimes-test-depends)
     set(check-runtimes-${name} check-runtimes)
     list(APPEND ${name}_test_targets runtimes-test-depends-${name} check-runtimes-${name})
+    list(APPEND test_targets ${${name}_test_targets})
     foreach(target_name IN LISTS SUB_CHECK_TARGETS)
       set(${target_name}-${name} ${target_name})
       list(APPEND ${name}_test_targets ${target_name}-${name})


        


More information about the llvm-commits mailing list