[PATCH] D110740: Do not emit prologue_end for line 0 locs

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham added inline comments.


================
Comment at: llvm/test/DebugInfo/MIR/X86/debug-loc-0.mir:7
+# CHECK: .loc 1 0 0
+# CHECK-NOT: .loc 1 0 0 prologue_end
+# CHECK: .loc 1 37 1 prologue_end
----------------
rastogishubham wrote:
> probinson wrote:
> > This change looks like it causes the test to stop verifying what the comment on line 1 says: collapse line-0 directives.  The changed test would pass if we emitted
> > ```
> > .loc 1 0 0
> > .loc 1 0 0
> > .loc 1 37 1 prologue_end
> > ```
> > which is not what this test wants.
> I see what my error is here, so I assume this test is trying to see that multiple line 0 locs should be collapsed into one. So all I need to do is something like.
> 
> 
> ```
> # CHECK: Ltmp0:
> # CHECK: .loc 1 0 0
> # CHECK-NOT: .loc 1 0 0
> ```
I meant:


```
# CHECK: Ltmp0:
# CHECK: .loc 1 0 0
# CHECK-NOT: .loc 1 0 0
# CHECK: .loc 1 37 1 prologue_end
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110740/new/

https://reviews.llvm.org/D110740