[PATCH] D110747: [NFC] Restore magic and magicu to a globally visible location

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 13:34:49 PDT 2021


lattner added a comment.

Cool, thank you for pulling this back, I'm sorry for the breakage.  I think that adding this to its own header makes a lot of sense.  While you're here, please rename the structs and functions.  this shouldn't be called `llvm::magic`, the names should reference division by a constant somehow.  Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110747/new/

https://reviews.llvm.org/D110747



More information about the llvm-commits mailing list