[PATCH] D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO

[William Woodruff via Phabricator via llvm-commits]

woodruffw added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeAnalyzer.cpp:747
   if (BlockID == bitc::BLOCKINFO_BLOCK_ID) {
-    if (O)
+    if (O && !O->DumpBlockinfo)
       O->OS << Indent << "<BLOCKINFO_BLOCK/>\n";
----------------
tejohnson wrote:
> Why this change?
Without it, the dumper will prematurely emit the end of the `BLOCKINFO_BLOCK`. 

There are two cases:

* Not dumping the `BLOCKINFO_BLOCK` (the default): emit an empty XML-element-thingy
* Dumping the `BLOCKINFO_BLOCK`: actually visit the `BLOCKINFO_BLOCK`, and let its dumper handle the fully XML-element-thingy



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107536/new/

https://reviews.llvm.org/D107536