[PATCH] D107378: Make enum iteration with seq safe by default

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 12:44:31 PDT 2021


kuhar added inline comments.


================
Comment at: llvm/include/llvm/ADT/Sequence.h:9-33
+/// Provides some synthesis utilities to produce sequences of values. The names
+/// are intentionally kept very short as they tend to occur in common and
+/// widely used contexts.
+///
+/// The `seq(A, B)` function produces a sequence of values from `A` to up to
+/// (but not including) `B`, i.e., [`A`, `B`), that can be safely iterated over.
+/// `seq` supports both integral (e.g., `int`, `char`, `uint32_t`) and enum
----------------
dblaikie wrote:
> might be good to commit this part separately before the rest, since it's not related to the enum stuff being added in the rest of this patch?
Good idea, I opened https://reviews.llvm.org/D110760.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107378/new/

https://reviews.llvm.org/D107378



More information about the llvm-commits mailing list