[PATCH] D110686: [fir] Move parser/printer/verifier of fir.string_lit and add builders

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/include/flang/Optimizer/Dialect/FIROps.td:2789
+  let builders = [
+    OpBuilder<(ins "fir::CharacterType":$in_type,
+      "llvm::StringRef":$value,
----------------
mehdi_amini wrote:
> Nit: `inType` for consistency between declaration and definition.
Good catch! Thanks for the review. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110686/new/

https://reviews.llvm.org/D110686