[PATCH] D110730: [SystemZ][z/OS] Introduce initial support for GOFF asm parser

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 10:48:46 PDT 2021


uweigand added inline comments.


================
Comment at: llvm/unittests/MC/SystemZ/SystemZAsmLexerTest.cpp:128
+
+class SystemZAsmLexerZOS : public SystemZAsmLexerTest {
+protected:
----------------
Kai wrote:
> The name should be `SystemZAsmLexerzOS` - as the name of the OS is z/OS.
On the other hand, as the first letter of a component in camel case, shouldn't the "z" still be capitalized?  LexerzOS looks a bit weird to me :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110730/new/

https://reviews.llvm.org/D110730



More information about the llvm-commits mailing list