[PATCH] D110719: [Mangler] Calculate the argument list byte count suffix correctly when returning large values

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 10:48:31 PDT 2021


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

For what it's worth, this issue is not observable from clang because clang does this mangling in the frontend. See https://godbolt.org/z/GM1Evjj3Y, it produces the function name `\01_return_large at 0`. Looking at the code suggests that this is just an accident. It works because it is driven by the AST, which doesn't have the implicit sret parameter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110719/new/

https://reviews.llvm.org/D110719



More information about the llvm-commits mailing list