[PATCH] D108394: add tsan shared library

Zijun Zhao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 10:41:04 PDT 2021


ZijunZhao marked 13 inline comments as done.
ZijunZhao added inline comments.


================
Comment at: compiler-rt/test/tsan/CMakeLists.txt:19
 endif()
 
 set(TSAN_TESTSUITES)
----------------
danalbert wrote:
> vitalybuka wrote:
> > 
> I think this is still needed? This list is missing most of the deps.
> 




================
Comment at: compiler-rt/test/tsan/CMakeLists.txt:19
 endif()
 
 set(TSAN_TESTSUITES)
----------------
ZijunZhao wrote:
> danalbert wrote:
> > vitalybuka wrote:
> > > 
> > I think this is still needed? This list is missing most of the deps.
> > 
> 
> 
If there is no need for unit test, I suppose 
```
list(APPEND TSAN_DYNAMIC_TEST_DEPS TsanDynamicUnitTests)
```
should be deleted as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108394/new/

https://reviews.llvm.org/D108394



More information about the llvm-commits mailing list