[PATCH] D110714: [Flang][openmp] Added semantic checks for atomic construct

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:13
 #include <algorithm>
-
 namespace Fortran::semantics {
----------------
Same as in the other patch. Looks like you have an editor config that remove blank line here. Please just keep it. 


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:41
+// OpenMPAtomicConstruct
+class OmpAtomicConstructChecker {
+public:
----------------
Might be cleaner in its own file?


================
Comment at: flang/lib/Semantics/check-omp-structure.h:230
   void CheckCycleConstraints(const parser::OpenMPLoopConstruct &x);
+  void CheckOmpAtomicConstructStructure(const parser::OpenMPAtomicConstruct &);
   void CheckDistLinear(const parser::OpenMPLoopConstruct &x);
----------------
Nit: Other checks do not mention `Omp`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110714/new/

https://reviews.llvm.org/D110714