[PATCH] D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution

Wed Sep 29 08:45:51 PDT 2021

clementval added inline comments.

================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:13
 #include <algorithm>
-
 namespace Fortran::semantics {
----------------
NimishMishra wrote:
> clementval wrote:
> > unrelated change?
> Not sure what's caused this. Could it be possible that git-clang-format introduced these?
Quite unlikely but who knows :-) If you can just undo the change it would be great. 

================
Comment at: flang/test/Semantics/omp-sync-critical02.f90:17
+
+end function timer_tick_sec
----------------
NimishMishra wrote:
> clementval wrote:
> > I'm not sure I follow what this test adds to the same code in `omp-sync-critical01.f90`...
> I added this verbatim from the artifact at https://bugs.llvm.org/show_bug.cgi?id=48145. Should I remove it?
Looks like it is tested in your `omp-sync-critical01.f90` so if it's a duplicate just remove it. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110502/new/

https://reviews.llvm.org/D110502