[PATCH] D110712: [LoopFlatten] Bail if we can't perform flattening after IV widening

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopFlatten.cpp:755
+  if (FI.Widened && !CanFlatten)
+    return false;
+
----------------
dmgreen wrote:
> I think false means "the code didn't change". But it will have had phi's widened so should be returning true?
Hmmm.... interesting. So, yes, it makes a change, but not the one we were expecting, i.e. not the flattening (which is what this whole TODO is about). So I am not sure if we want or should be returning true, but given that it is making a code change, probably better to do so. I will change that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110712/new/

https://reviews.llvm.org/D110712