[PATCH] D108253: [WIP][X86] Introduce 'blend with broadcast' shuffle lowering strategy (PR50971)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:12798
+                                              /*BlendOfIdentitiesOnly=*/true);
+}
+
----------------
RKSimon wrote:
> lowerShuffleAsDecomposedShuffleMerge does some of this already - can we not extend that?
I'm not following. That is exactly what i'm doing here, extending `lowerShuffleAsDecomposedShuffleMerge()`.
The point of `lowerShuffleAsBlendOfIdentities()` is to be able to run the relevant portion
of `lowerShuffleAsDecomposedShuffleMerge()` at some earlier point
(before the full ` ​lowerShuffleAsDecomposedShuffleMerge()` invocation),
catching the target pattern only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108253/new/

https://reviews.llvm.org/D108253