[PATCH] D110694: [flang][driver] Error if uuidgen is not installed

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

Thanks for the improvement, LGTM! Added Steve as a reviewer - he's the only user of this script that I am aware of :) Shall we wait a day to see whether he's got any comments?



================
Comment at: flang/tools/f18/flang:361-365
+  if ! command -v uuidgen &> /dev/null
+  then
+    echo "uuidgen is required for generating unparsed file names."
+    exit 1
+  fi
----------------
[nit] I would move this change above the comments (they only apply to L367 and L368). Perhaps add a quick justification explaining _why_ we need a check for this particular utility. It's already documented in the commit message, so perhaps that would be overkill? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110694/new/

https://reviews.llvm.org/D110694