[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 05:31:11 PDT 2021


thakis added a comment.

Softlinks don't work on Windows, that's why these tests use copies.

clang_f_opts.c sadly started flaking almost immediately after this went in: http://45.33.8.238/win/46115/step_7.txt

So I fear the Windows file system can't handle this patch as-is.

Maybe we can use `rm -f` and maybe that way the error isn't fatal even when deleting the file doesn't work, not sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110276/new/

https://reviews.llvm.org/D110276



More information about the llvm-commits mailing list