[PATCH] D110646: [SelectionDAG] Handle promotion + widening in getCopyToPartsVector

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:4999
+      EVT OpVT = Op.getValueType();
+      if (getTypeAction(OpVT) == TargetLowering::TypePromoteInteger)
+        Op = GetPromotedInteger(Op);
----------------
Is it worth asserting that the type action is either legal or promote here? I'm just thinking what would happen if the action was to widen?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:5008
+
+    // Do the CONCAT on the wider type, and finally truncate to (the promoted)
+    // NOutVT.
----------------
nit: Perhaps this should be 'promoted'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110646/new/

https://reviews.llvm.org/D110646