[PATCH] D110691: [MSP430] Recognize Bi as an indirect branch in analyzeBranch. NFC.

Wed Sep 29 03:53:23 PDT 2021

jozefl added a comment.

Instead of just ignoring Bi, I think we can handle it as we do with JMP. Bi is a direct, unconditional branch like JMP, it just has longer range.
See inline comments for suggestions.

Thanks!

================
Comment at: llvm/lib/Target/MSP430/MSP430InstrInfo.cpp:118
     if (I->getOpcode() != MSP430::JMP &&
         I->getOpcode() != MSP430::JCC &&
         I->getOpcode() != MSP430::Br &&
----------------
MSP430::Bi should be added here as well

================
Comment at: llvm/lib/Target/MSP430/MSP430InstrInfo.cpp:193
     // Handle unconditional branches.
     if (I->getOpcode() == MSP430::JMP) {
       if (!AllowModify) {
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110691/new/

https://reviews.llvm.org/D110691