[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

Nice!



================
Comment at: clang/lib/Basic/CLWarnings.cpp:17
+  switch (CLWarningID) {
+  case 4005: return "macro-redefined";
+  case 4018: return "sign-compare";
----------------
Would it be possible to reference the DiagGroup symbolically here somehow instead of using a string? That way, if the DiagGroup gets renamed, we don't risk forgetting to update this string.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110668/new/

https://reviews.llvm.org/D110668