[PATCH] D110577: [llvm-cxxfilt] Enable support for D programming language demangling

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 00:10:42 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

One nit, otherwise LGTM.



================
Comment at: llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp:21
 #include <cstdlib>
+#include <cstring>
 #include <iostream>
----------------
I don't think you need to include this header - `strncmp` is already used in this file, so it's clearly being included through the existing include hierarchy. See also https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110577/new/

https://reviews.llvm.org/D110577



More information about the llvm-commits mailing list