[PATCH] D109963: [AArch64] Split bitmask immediate of bitwise AND operation

Tue Sep 28 18:33:32 PDT 2021

jaykang10 added a comment.

In D109963#3029134 <https://reviews.llvm.org/D109963#3029134>, @saugustine wrote:

> Since we have a reproducer, I have reverted this change with rGc07f7099690e <https://reviews.llvm.org/rGc07f7099690e8607d119227db1f80ee21eff3a3b>.

Sorry for the error.

I have fixed it and I can see the reproducer from @haowei is passed. After checking tests and benchmarks again, let me try to push this patch again.

================
Comment at: llvm/lib/Target/AArch64/AArch64MIPeepholeOpt.cpp:132
+  // If it is SUBREG_TO_REG, check its operand.
+  if (MovMI->getOpcode() == TargetOpcode::SUBREG_TO_REG) {
+    SubregToRegMI = MovMI;
----------------
craig.topper wrote:
> Do you need to check if the SUBREG_TO_REG has multiple uses?
You are right! I need to check it as well as `mov`. Thanks @craig.topper!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109963/new/

https://reviews.llvm.org/D109963