[PATCH] D110660: [WIP][AsmParser] handle .align 0 per MCAsmInfo

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 28 16:06:34 PDT 2021


craig.topper added a comment.

In D110660#3028842 <https://reviews.llvm.org/D110660#3028842>, @craig.topper wrote:

> In D110660#3028806 <https://reviews.llvm.org/D110660#3028806>, @nickdesaulniers wrote:
>
>> (oh, this is actually good enough to fix pr/51929). Maybe I can add a fixme to the test on the Size noting that GAS adds explicit nops. We don't necessarily need the nops; we need to not treat `.align 0` as `.align 1` on THUMB2 (and probably ARM; unverified).
>
> Is this an issue for RISCV too?

Nevermind, after poking around I see this is a specific to ARM in gas.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110660/new/

https://reviews.llvm.org/D110660



More information about the llvm-commits mailing list