[PATCH] D110363: [DWARF][NFC] add ParentIdx and SiblingIdx to DWARFDebugInfoEntry for faster navigation.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D110363#3028518 <https://reviews.llvm.org/D110363#3028518>, @avl wrote:

>> (though, honestly - if some operations require the underlying array anyway - I think using absolute indexes is probably reasonable unless there's some compelling performance issues)
>
> My understanding is that from performance point of view indexes and deltas - are equal:
>
> "DieArray.begin() + ParentIdx"  vs "this + ParentRelativeOffset"

There's the potential for /some/ performance difference here since accessing the DieArray requires dereferencing 'this' - so there a memory access in the first case, and none (just pointer arithmetic) in the second. But yeah, I'd be surprised if it made an observable difference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110363/new/

https://reviews.llvm.org/D110363