[PATCH] D110660: [WIP][AsmParser] handle .align 0 per MCAsmInfo

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/include/llvm/MC/MCAsmInfo.h:861
+  /// .align 0 may have architecture specific meaning.
+  virtual void handleAlignmentZero(int64_t *Alignment) const;
 };
----------------
craig.topper wrote:
> Why not make Alignment a reference?
It's been beaten into my head the Google C++ coding style where in/out params are passed by pointer, so that it's obvious at the call site that they're being modified since their address must be taken. If this is explicitly not the LLVM style guide, I'm happy to change it to a non-const reference.

(The Google C++ coding style recommends const-reference params or pointer params; for in vs in-out params).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110660/new/

https://reviews.llvm.org/D110660