[PATCH] D110105: [MachineInstr] Move MIParser's DBG_VALUE RegState::Debug invariant into MachineInstr::addOperand
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 28 13:49:46 PDT 2021
MatzeB added a comment.
Seems to me that the most important thing would be to add a check to `MachineVerifier` so we consistently catch problems. Adding automation to `addOperand` is fine, but there are enough ways to change instructions and operands with other APIs.
If you could find the time to add a check to MachineVerifier that would be fantastic! Though we can also leave that for another time, up to you.
Changes so far look fine, but if you add the automation, could you go through the sourcecode and remove manual usage of `setIsDebug()` then?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110105/new/
https://reviews.llvm.org/D110105
More information about the llvm-commits
mailing list