[PATCH] D110609: [CodeGen] Fix wrapping personality symbol on ARM

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

> and then the ARM backend attempts to change the binding to global, which causes an error.

Elaborate the error.



================
Comment at: lld/test/ELF/lto/arm-wrap-personality.ll:1
+; Wrapped symbols are marked as weak for LTO to inhibit IPO. The ARM backend was
+; previously explicitly marking the personality function as global, so if we
----------------
We repeat the comment marker (e.g. `;; `) for non-RUN non-CHECK lines in lld/test/ELF and some binary utilities


================
Comment at: lld/test/ELF/lto/arm-wrap-personality.ll:15
+; CHECK: GLOBAL {{.*}} __wrap___gxx_personality_v0
+; this should be GLOBAL when PR52004 is fixed.
+; CHECK: WEAK {{.*}} __gxx_personality_v0
----------------
`;;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110609/new/

https://reviews.llvm.org/D110609