[PATCH] D110438: [BPI] Keep BPI available in loop passes through LoopStandardAnalysisResults

Di Mo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 28 12:03:26 PDT 2021


modimo accepted this revision.
modimo added a comment.

In D110438#3027462 <https://reviews.llvm.org/D110438#3027462>, @anna wrote:

> The removed code in LoopPredication (which removes BPI calculation per Loop predication invocation) shows the testcase difference.  I was hoping to keep the loop predication change separate to save some downstream merge headaches, but couldn't show a testcase for the standalone original change in this review.

I think it makes sense as part of this change given LoopStandardAnalysisResults now stores BPI, so calculating it separately in LoopPredication is a waste.

Make sure to update the description before pushing, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110438/new/

https://reviews.llvm.org/D110438



More information about the llvm-commits mailing list