[PATCH] D110620: [SCEV] Infer ranges for SCC consisting of cycled Phis

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Compile-time impact looks okay: https://llvm-compile-time-tracker.com/compare.php?from=a7d084a18de736e0ed750c67c5851fa6b2a085f5&to=06e833e5593c85cc6aed401b1a186d9257c10484&stat=instructions



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:6266
+              if (PendingPhiRanges.count(PhiOp))
+                continue;
+              if (Reachable.insert(PhiOp).second)
----------------
Why is it okay to ignore operands in PendingPhiRanges here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110620/new/

https://reviews.llvm.org/D110620