[PATCH] D110491: [Polly] Check the properties of accesses to operands of a matrix-matrix multiplication

Roman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 28 10:59:57 PDT 2021


gareevroman added a comment.

In D110491#3026237 <https://reviews.llvm.org/D110491#3026237>, @Meinersbur wrote:

> The test need an assertions-enabled build (`REQUIRES: asserts`) to print anything. That is, it will always pass on non-assert builds.

Thanks for the review! I have updated the test case to take it into the account.

> I am still accepting the patch in the interest of getting this fixed. However, I may replace the test by something else, e.g. by checking that the output with and without the flag is the same.

Could the ast be checked for this purpose?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110491/new/

https://reviews.llvm.org/D110491



More information about the llvm-commits mailing list