[PATCH] D110640: [SLPVectorizer] Fix crash in isShuffle with scalable vectors
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 28 10:34:45 PDT 2021
ABataev added a comment.
In D110640#3028002 <https://reviews.llvm.org/D110640#3028002>, @kmclaughlin wrote:
> Hi @abataev, I've added a fix for this assertion failure in the same place as you suggested on a previous patch, D104809 <https://reviews.llvm.org/D104809>. Since this is quite similar and there would now be two fixes in `buildTree_rec` for the same issue, I was wondering if you think it's worth revisiting the fix @CarolineConcatto first proposed on that patch? Her first revision added the `phiNodeHasScalableOp` & `basicBlockHasScalableOp` functions to avoid vectorizing early if there are any instructions found with scalable types.
I think the current implementation is still good. Also, isShuffle is called in several places, which one causes the crash?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110640/new/
https://reviews.llvm.org/D110640
More information about the llvm-commits
mailing list