[PATCH] D110561: [AArch64] Alter arith-cbz-fusion to fuse between pairs register instructions
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 28 10:14:29 PDT 2021
MatzeB added a comment.
> This code adds an SDep::Artificial dependency between the instruction and ExitSU:
But ExitSU is an artificial node not an to mark the end of the schedule graph. I don't think it makes sense trying to macro-fuse ExitSU with anything.
The thing that is odd with this diff is that it adds extra checks to one particular rule (`isArithmeticCbzPair`) while it seems to me that if this is required, then all the other rules are problematic in the same sense; so we'd better understand why and find a general fix.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110561/new/
https://reviews.llvm.org/D110561
More information about the llvm-commits
mailing list