[PATCH] D110630: [DebugInfo][InstrRef] Use PHI placement utilities for variable-value calculations

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/unittests/CodeGen/InstrRefLDVTest.cpp:507
 
   // Name some values.
   ValueIDNum LiveInRsp(0, 0, RspLoc);
----------------
Over in D110173 I said:
> I think that the tests, especially this one, would be easier to read if there was a comment mapping the block numbers to the block names used in the CFG comment at the start of each test. Or, slightly more radically, replace the integer literals with a name. E.g.
> ```
> const uint64_t Entry = 0, Loop1 = ...;
> LiveInRsp(Entry, 0, RspLoc);
> ```
I think this is even more desirable now with the block-layout-function refactor.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110630/new/

https://reviews.llvm.org/D110630