[PATCH] D109889: AMDGPU: Broadcast scalar boolean to vector boolean explicitly

Alexander via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 28 09:35:32 PDT 2021


alex-t added a comment.

> The problem is "COPY from SCC" by itself is not a semantically meaningful concept. We can make up whatever we want. I think ZeroOrOneBooleanContent is a better choice, since it's not fighting an uphill battle for optimization priority, and there really is only one bit. Places that semantically need to use -1 can emit the select directly.

Could you please explain, why we have chosen the ZeroOrOneBooleanContent over the ZeroOrNegativeOneBooleanContent? 
Is there any strong reason? For the divergent target the latter looks more natural. I remember we already had the same discussion but I did not get persuaded :)

Now we have a set of hacks intended to fix the consequences of that decision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109889/new/

https://reviews.llvm.org/D109889



More information about the llvm-commits mailing list