[PATCH] D110576: [Demangle] Add support for D programming language

Luís Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 28 08:23:22 PDT 2021


ljmf00 added a comment.

In D110576#3027009 <https://reviews.llvm.org/D110576#3027009>, @dblaikie wrote:

> As with the Rust demangling (check the commit history, it was done earlier this year), I think this'd be easier to review if it were implemented incrementally - it'll be easier to spot the test coverage for each feature as it's added. Otherwise, it's a lot of code to try to validate in one piece.

Well, this is actually a port so it is harder to split up and the logic is well refactored since it is split up according to D mangling ABI nodes. I can split this into independent ABI nodes and incrementally add features like template demangling, although this will radically increase work on my side since I need to manually rewrite it to be incrementally independent patches.

About the coverage, I can't find where the coverage is officially reported. https://llvm.org/reports/coverage/ points to a very outdated report.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110576/new/

https://reviews.llvm.org/D110576



More information about the llvm-commits mailing list