[PATCH] D110390: [SCEV] Establish control over disposition caches

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 28 07:56:10 PDT 2021


mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:7548
+  forgetLoopDispositions();
+  forgetBlockDispositions();
 }
----------------
nikic wrote:
> This looks like a really big hammer that goes against how SCEV invalidation normally works. Note that the loop above is supposed to walk all SCEVs based on the value and calls `forgetMemoizedResults()` for them -- this includes clearing the loop and block dispositions.
You are correct, I'll remove it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110390/new/

https://reviews.llvm.org/D110390



More information about the llvm-commits mailing list