[PATCH] D110558: [DebugInfo][LoopStrengthReduction] Prevent attempts to translate long SCEV expressions

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 28 04:04:49 PDT 2021


StephenTozer added a comment.

In D110558#3027018 <https://reviews.llvm.org/D110558#3027018>, @chrisjackson wrote:

> Applied clang-format.

Looks like this didn't actually apply, the revision is showing this update as having applied no changes and the formatting issues are still present.

I also suppose it would be good if we could have the expression limit put as a variable with an explanatory comment, rather than a magic number. Other than that, this change LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110558/new/

https://reviews.llvm.org/D110558



More information about the llvm-commits mailing list