[PATCH] D110595: [llvm-objdump] Fix -R display and support ET_EXEC

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one other suggestion.



================
Comment at: llvm/test/tools/llvm-objdump/ELF/dynamic-relocs.test:19-20
+
+# RUN: yaml2obj --docnum=2 -DTYPE=ET_DYN %s -o %t2
+# RUN: llvm-objdump -R %t2 | FileCheck %s --strict-whitespace --match-full-lines
+
----------------
It might be interesting to perform one of these runs (or an additional run) with an arbitrary ELF type e.g. 0x1234, to better show that the type doesn't matter at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110595/new/

https://reviews.llvm.org/D110595