[PATCH] D110603: [GlobalISel][IRTranslator] Emit trap intrinsic for unreachable

Mon Sep 27 22:08:45 PDT 2021

aemerson added a comment.

In D110603#3026589 <https://reviews.llvm.org/D110603#3026589>, @aemerson wrote:

> Unfortunately this regresses code size (as expected) by 0.1% geomean on -Os CTMark:
>
>   Program             outputgHVrPT outputLpdj4U diff 
>    7zip-benchmark      569484       570496       0.2%
>    clamscan            382376       382744       0.1%
>    pairlocalalign      248908       249140       0.1%
>    consumer-typeset    418972       419224       0.1%
>    sqlite3             287088       287236       0.1%
>    kc                  432524       432736       0.0%
>    bullet              475372       475596       0.0%
>    lencod              429576       429764       0.0%
>    tramp3d-v4          365880       365916       0.0%
>    SPASS               412852       412880       0.0%
>    Geomean difference                            0.1%
>
> We'll have to eat this and make up for it elsewhere.

However, when you add this patch on top of D110610 <https://reviews.llvm.org/D110610> and D98200 <https://reviews.llvm.org/D98200> the incremental regression is very minor.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110603/new/

https://reviews.llvm.org/D110603