[PATCH] D110365: [llvm][profile] Add padding after binary IDs

Leonard Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 27 16:18:49 PDT 2021


leonardchan added a comment.

In D110365#3026182 <https://reviews.llvm.org/D110365#3026182>, @phosek wrote:

> LGTM the only question is whether these tests shouldn't rather live in `compiler-rt/test/profile`?

I think llvm might be better since they're more for checking that the reader operates properly on some profdata rather than explicitly checking what the profdata is. That said, I do think there should be perhaps a compiler-rt test here for checking that the profile runtime generates the correct data. I'll add one shortly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110365/new/

https://reviews.llvm.org/D110365



More information about the llvm-commits mailing list