[PATCH] D109227: [flang] GET_COMMAND_ARGUMENT(LENGTH) runtime implementation

Mon Sep 27 14:45:51 PDT 2021

klausler added inline comments.

================
Comment at: flang/include/flang/Runtime/command.h:36
 // Returns a STATUS as described in the standard.
 CppTypeFor<TypeCategory::Integer, 4> RTNAME(ArgumentValue)(
+    CountType n, const Descriptor *value, const Descriptor *errmsg);
----------------
std::int32_t

================
Comment at: flang/include/flang/Runtime/command.h:18

+using CountType = CppTypeFor<TypeCategory::Integer, 4>;
+using LengthType = CppTypeFor<TypeCategory::Integer, 8>;
----------------
klausler wrote:
> I think that you can use std::int32_t/std::int64_t here.
I meant that you don't need to have the type aliases CountType, LengthType, &c. either.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109227/new/

https://reviews.llvm.org/D109227