[PATCH] D107899: [PowerPC] Implement builtin for vbpermd

[Lei Huang via Phabricator via llvm-commits]

lei accepted this revision as: lei.
lei added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/lib/Headers/altivec.h:17337
 static __inline__ vector long long __ATTRS_o_ai
 vec_vbpermq(vector unsigned char __a, vector unsigned char __b) {
   return __builtin_altivec_vbpermq(__a, __b);
----------------
bmahjour wrote:
> This should be guarded under P8. It would also be good to add a `vec_vbpermd(vector unsigned long long ...)` counter part under `__POWER9_VECTOR__` for consistency.
I think this is actually guarded under ` __POWER8_VECTOR__`.  See line 17237.
As far as I can see, there is no LLVM intrinsic corresponding to vbpermd.


================
Comment at: clang/lib/Headers/altivec.h:17352
+}
+#endif
+#ifdef __POWER9_VECTOR__
----------------
nit: It would be more clear if we had a comment here what this endif if for.  I assume it's `/* __POWER8_VECTOR__ */`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107899/new/

https://reviews.llvm.org/D107899