[PATCH] D110580: [THUMB2] default .text alignment to 2B

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 27 14:02:00 PDT 2021


MaskRay added a comment.

Like the RISCV patch, the test should be in llvm/test/MC/ARM. test/CodeGen/ARM does not test pure `lib/MC` behavior.



================
Comment at: llvm/test/CodeGen/ARM/thumb-text-align.s:1
+// RUN: llvm-mc < %s -triple=thumbv7-linux-gnueabi -filetype=obj -o - \
+// RUN:   | llvm-readobj -S --sd - | FileCheck %s --check-prefixes=CHECK,CHECK-THUMB
----------------
`<` and `-o -` can be removed


================
Comment at: llvm/test/CodeGen/ARM/thumb-text-align.s:7
+
+// CHECK:    Name: .text (1)
+// CHECK-NEXT:    Type: SHT_PROGBITS (0x1)
----------------
Align the keys (Name, Type, etc)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110580/new/

https://reviews.llvm.org/D110580



More information about the llvm-commits mailing list