[PATCH] D110584: [Analysis] Be defensive when matching size_t in lib call signatures

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 27 13:56:35 PDT 2021


nikic added a reviewer: nikic.
nikic added a comment.

I think the "optional DataLayout" part here is just an unused leftover. If I add an `assert(DL)` in getLibFunc() (the only caller of isValidProtoForLibFunc()) I don't get any test failures. I'd recommend just making DataLayout explicitly required. Assert / make it a reference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110584/new/

https://reviews.llvm.org/D110584



More information about the llvm-commits mailing list