[PATCH] D110583: [Analysis] Add FIXME:s related to size_t type checks

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope created this revision.
Herald added a subscriber: hiraditya.
bjope requested review of this revision.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110583

Files:
  llvm/lib/Analysis/TargetLibraryInfo.cpp


Index: llvm/lib/Analysis/TargetLibraryInfo.cpp
===================================================================
--- llvm/lib/Analysis/TargetLibraryInfo.cpp
+++ llvm/lib/Analysis/TargetLibraryInfo.cpp
@@ -729,9 +729,19 @@
                                                    LibFunc F,
                                                    const DataLayout *DL) const {
   LLVMContext &Ctx = FTy.getContext();
+  // FIXME: There is really no guarantee that sizeof(size_t) is equal to
+  // sizeof(int*) for every target. So the assumption used here to derive the
+  // SizeTTy based on DataLayout and getIntPtrType isn't always valid.
   Type *SizeTTy = DL ? DL->getIntPtrType(Ctx, /*AddressSpace=*/0) : nullptr;
   auto IsSizeTTy = [SizeTTy](Type *Ty) {
-    return SizeTTy ? Ty == SizeTTy : Ty->isIntegerTy();
+    // FIXME: For uknown historical reasons(?) we use a relaxed condition saying
+    // that any integer type may size_t, for example if we got no
+    // DataLayout. This seems like a potentially error prone relaxation (or why
+    // should we only be more strict and checking the exact type when we have a
+    // DataLayout?).
+    if (!SizeTTy)
+      return Ty->isIntegerTy();
+    return Ty == SizeTTy;
   };
   unsigned NumParams = FTy.getNumParams();
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110583.375389.patch
Type: text/x-patch
Size: 1275 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210927/e5e19589/attachment.bin>