[PATCH] D109764: [NFC] [PSI] explain encoding of PercentileCutoff.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 27 13:09:29 PDT 2021


fmayer marked an inline comment as done.
fmayer added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:138
+  /// PercentileCutoff is encoded as a 6 digit decimal fixed point number, where
+  /// the first two digits are the whole part. E.g. 995000 for 99.5 percentile.
   bool isHotCountNthPercentile(int PercentileCutoff, uint64_t C) const;
----------------
mtrofin wrote:
> I don't think I'd understand what 'whole part' means, but the example is perfectly sufficient. I'd just leave it to the example.
I would leave it, it doesn't do harm and is the technical description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109764/new/

https://reviews.llvm.org/D109764



More information about the llvm-commits mailing list