[PATCH] D110534: [llvm-reduce] Reduce metadata references.

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/tools/llvm-reduce/remove-metadata-args.ll:11
+
+; Boring stuff's metadata must have been removed.
+; REDUCED-NOT: Boring {{.*}} !md !0
----------------
Meinersbur wrote:
> aeubanks wrote:
> > should add a couple things to check for just to make sure we didn't accidentally reduce everything
> The RUN at line 2 tests this by checking the existence of all the "EXCITING" lines. I started using `--check-prefixes=EXCITING,REDUCED` but then I would add NOT lines between all the INTERESTING lines. Would something like `REDUCED-DAG-NOT` or `REDUCED-NOT-DAG` work?
Actually I changed my mind, I think this is good enough. If the output isn't passing the interestingness test there's something seriously wrong

And the RUN at line 2 is redundant with the internal llvm-reduce check that the input is interesting
Generally I think just the llvm-reduce RUN and the FileCheck for the reduced file RUN are good enough


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110534/new/

https://reviews.llvm.org/D110534