[PATCH] D110466: [llvm-profgen][CSSPGO] On-demand function size computation for preinliner
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 27 10:37:42 PDT 2021
hoy accepted this revision.
hoy added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:446
+ std::unordered_map<uint64_t, uint64_t> FuncRanges;
+ // Go through all the range in the CS counters, use the start of the range to
+ // look up the function it belongs and record the function range
----------------
nit: range -> ranges
================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:552
+ if (CodeAddrs[Index] != StartOffset)
+ WithColor::warning() << "Invalid function start instruction at "
+ << format("%8" PRIx64, StartOffset) << "\n";
----------------
nit: "Invalid function start" -> "Invalid start"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110466/new/
https://reviews.llvm.org/D110466
More information about the llvm-commits
mailing list