[PATCH] D110534: [llvm-reduce] Reduce metadata references.

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 27 10:37:21 PDT 2021


aeubanks added inline comments.


================
Comment at: llvm/test/tools/llvm-reduce/remove-metadata-args.ll:13
+; REDUCED-NOT: Boring {{.*}} !md !0
+; REDUCED-NOT: !md !0 {{.*}} Boring
+
----------------
jeroen.dobbelaere wrote:
> Just wondering: given the spaces around the matcher, will this have the wanted effect ? Aka, if you give the checker the original input, will it fail ?
llvm-reduce should automatically check that the input is interesting and fail out if it isn't, so I don't think we need the extra RUN lines. We just need to check if the output is correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110534/new/

https://reviews.llvm.org/D110534



More information about the llvm-commits mailing list