[PATCH] D110468: [AMDGPU] Do not internalize ASan device library functions.
Brian Sumner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 27 10:12:04 PDT 2021
b-sumner added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:520
if (const Function *F = dyn_cast<Function>(&GV))
- return F->isDeclaration() || AMDGPU::isEntryFunctionCC(F->getCallingConv());
+ return F->isDeclaration() || F->getName().startswith("__asan_") ||
+ AMDGPU::isEntryFunctionCC(F->getCallingConv());
----------------
pvellien wrote:
> there are two asan device functions that don't start with "__asan_*" prefix, they are the following:
> 1. __sanitizer_ptr_cmp
> 2. __sanitizer_ptr_sub
> @b-sumner do we want to not internalize those functions?
Yes, I think __sanitizer_* should be handled similarly to __asan_*
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110468/new/
https://reviews.llvm.org/D110468
More information about the llvm-commits
mailing list