[PATCH] D110292: Use a deterministic order when updating the DominatorTree

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BasicBlockUtils.cpp:234
     SmallPtrSet<BasicBlock *, 2> SuccsOfPredBB(succ_begin(PredBB),
-                                               succ_begin(PredBB));
-    Updates.reserve(Updates.size() + 2 * SuccsOfBB.size() + 1);
+                                               succ_end(PredBB));
+    Updates.reserve(Updates.size() + 2 * succ_size(BB) + 1);
----------------
foad wrote:
> This line looks like a bug fix -- or does it just avoid doing some unnecesssary updates?
This will go away when rebasing. It was pre committed as: https://reviews.llvm.org/rG85a586501bcc5b556d34a566b9d256d56d6fc5ba


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110292/new/

https://reviews.llvm.org/D110292